Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-table): add requiredSort option to table #9487

Open
wants to merge 1 commit into
base: v3.x
Choose a base branch
from

Conversation

dequubi
Copy link

@dequubi dequubi commented Oct 14, 2024

cherry-pick

Co-authored-by: 40oleg [email protected]

(cherry picked from commit 38c5b20)

Copy link

lumberjack-bot bot commented Oct 14, 2024

Failed tests ❌

After <= Diff => Before

combo-box/combo-box.cy.ts/__diff_output__/correct-word-match-when-strict-backspaced-false.diff.png
combo-box/combo-box.cy.ts/__diff_output__/correct-word-match-when-strict-false.diff.png
combo-box/combo-box.cy.ts/__diff_output__/correct-word-match-when-strict-focused-2-false.diff.png
combo-box/combo-box.cy.ts/__diff_output__/correct-word-match-when-strict-focused-false.diff.png
combo-box/combo-box.cy.ts/__diff_output__/correct-word-match-when-strict-remove-all-false.diff.png
combo-box/combo-box.cy.ts/__diff_output__/search-should-not-be-reset-strict-backspaced-true.diff.png
combo-box/combo-box.cy.ts/__diff_output__/search-should-not-be-reset-strict-focused-true.diff.png
combo-box/combo-box.cy.ts/__diff_output__/search-should-not-be-reset-strict-remove-all-true.diff.png
combo-box/combo-box.cy.ts/__diff_output__/search-should-not-be-reset-strict-true.diff.png
combo-box/combo-box.cy.ts/__diff_output__/search-should-not-be-reset-strict-waited-mark-true.diff.png
input/input-table.cy.ts/components/__diff_output__/input_table__0_1.diff.png
input/input-table.cy.ts/components/__diff_output__/input_table__1_3.diff.png
input/input-table.cy.ts/components/__diff_output__/input_table__2_3.diff.png

(updated for commit 3204fc5)

@splincode splincode changed the title feat(addon-table): add requiredSort option to table (#9036) v3 feat(addon-table): add requiredSort option to table Oct 14, 2024
@splincode splincode added the v3 label Oct 14, 2024
Copy link

bundlemon bot commented Oct 14, 2024

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+397.41KB +10%
demo/browser/vendor.(hash).js
+214.53KB +10%
demo/browser/runtime.(hash).js
+42.05KB +10%
demo/browser/polyfills.(hash).js
+15.2KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +670.59KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.45MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants